Add the jj-core (alternative to #9766) - #9933
Merged
Merged
Conversation
yuja
reviewed
Aug 8, 2026
yuja
approved these changes
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
This will be common base for building upon `jj` if you only want the internals which make the other systems work, like the `Backend` or `WorkingCopy` trait. It should be of utmost importance to make the crate as low dependency as possible so it'ss not in the critical path during compilation. Part of #6284
martinvonz
force-pushed
the
mz/tnmnsuqstvxz
branch
from
August 18, 2026 03:07
ceab14c to
a2bc5ff
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
These modules are general-purpose algorithms with no dependencies on the rest of `jj-lib`, so they can move to the new low-dependency `jj-core` crate. `jj-lib` re-exports them, so its API is unchanged. Part of #6284
`jj-lib` re-exports it, so its API is unchanged. The `hashbrown` dependency moves along with it since `diff` was its only user in `jj-lib`. Part of #6284
`jj-lib` re-exports it, so its API is unchanged. Part of #6284
`jj-lib` re-exports it, so its API is unchanged. The tests need the `TestResult` alias that `jj-lib` has in its crate-level `tests` module, so `jj-core` gets a copy of that module. Part of #6284
martinvonz
force-pushed
the
mz/tnmnsuqstvxz
branch
from
August 18, 2026 03:43
a2bc5ff to
c3b3787
Compare
martinvonz
enabled auto-merge
August 18, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PhilipMetzger: I think this is a simple start. I hope it looks okay.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.